Avoid crasher when first token of a program is in error #695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used to give a crash in SourcePositiom, promoted by feeding its calculations with a negative offset.
Lines already start at 0, so columns should, too.
And adjust for it in DottyBackendInterface
Line numbers were wrong in previous file.
Seems partest adds code to the sources so that line numbers are not the same.
DarkDimius
added a commit
that referenced
this pull request
Jul 2, 2015
Avoid crasher when first token of a program is in error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to give a crash in SourcePositiom, promoted by feeding
its calculations with a negative offset.
Also, make lines and columns start at 0.
Review by @DarkDimius